[Improve] Show a bullet mask for preconfigured setup secret fields - #39
Merged
mrubens merged 1 commit intoJul 9, 2026
Merged
Conversation
When a runtime ENV or saved secret already satisfies a setup field, render the standard bullet mask so the field is visibly configured instead of looking empty.
Author
|
No code issues found. See task |
mrubens
marked this pull request as ready for review
July 9, 2026 16:01
mrubens
requested review from
brunobergher,
daniel-lxs and
mrubens
as code owners
July 9, 2026 16:01
mrubens
deleted the
improve/mask-preconfigured-inference-keys-1zelyqtejh7uc
branch
July 9, 2026 16:02
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
When a setup secret is already satisfied by a runtime ENV var (or a saved credential in the usual mask path), the field now shows the standard bullet mask (
••••••••…) instead of an empty input next to the checkmark. Applied on Configure inference, plus the same runtime-secret gap on compute and source-control setup secret fields.Why this change was made
A prepopulated inference key only showed a checkmark while the input looked blank, so it was unclear that a key was already configured. Masking matches the established settings pattern and makes the pre-filled state obvious without revealing the secret.
Impact
On setup steps with a configured secret, users see a filled masked field rather than an empty box. Empty still only means "no value yet." Focus-to-edit for saved keys is unchanged.