[Fix] Modal Regions shows as a password field in Compute settings - #28
Merged
Merged
Conversation
Author
|
No new code issues found. See task
|
mrubens
marked this pull request as ready for review
July 9, 2026 13:30
mrubens
requested review from
brunobergher,
daniel-lxs and
mrubens
as code owners
July 9, 2026 13:30
brunobergher
pushed a commit
that referenced
this pull request
Jul 9, 2026
Co-authored-by: Matt Rubens <2600+mrubens@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Modal Regions in Settings → Compute (and setup advanced Modal settings) is a plain-text field, not a password input. Saved non-secret values are shown as readable text instead of bullet masks.
Clearing a saved optional non-secret setting (for example emptying Modal Regions after it was saved) now counts as a pending change so Save stays enabled, and save removes the stale deployment env var. The form no longer re-applies saved prefill from unstable query identities while you are editing. Real secrets still treat empty input as "leave unchanged."
Why this change was made
Modal Regions is placement configuration, not a credential. Password-style masking made it hard to read and edit. Follow-up review also found that clearing a saved regions value left Save disabled (and left the value unchanged), and the clearing test could be skipped when runtime
MODAL_REGIONSleaked into CI/dev env.Impact
Operators can see, edit, and fully clear optional plain-text compute settings like Modal Regions without the UI undoing the clear. Password treatment remains for true secrets only.
Screenshots