[Feat] Add optional Modal sandbox region placement - #27
Merged
Conversation
Author
|
No code issues found. See task |
mrubens
marked this pull request as ready for review
July 9, 2026 11:19
mrubens
requested review from
brunobergher,
daniel-lxs and
mrubens
as code owners
July 9, 2026 11:19
brunobergher
pushed a commit
that referenced
this pull request
Jul 9, 2026
Co-authored-by: Matt Rubens <2600+mrubens@users.noreply.github.com>
brunobergher
pushed a commit
that referenced
this pull request
Jul 9, 2026
Co-authored-by: Matt Rubens <2600+mrubens@users.noreply.github.com>
brunobergher
added a commit
that referenced
this pull request
Jul 9, 2026
* ui * Update Teams app package manifest * Fix setup bootstrap admin sign-in * [Feat] Add optional Modal sandbox region placement (#27) Co-authored-by: Matt Rubens <2600+mrubens@users.noreply.github.com> * Fix setup OAuth redirect handling * Remove env vars info note from setup screens * Align sign-in page with setup styling * Keep setup auth callbacks on credential step * Fix Microsoft setup bootstrap admission * Continue setup after bootstrap auth * anonymous stats ui * Align comms settings setup flow * Layout fixes * Align reset password page with logged-out styling * Remove unused setup invoke import * Make setup helper declarations internal * Address auth review feedback * Fix StepInvoke test component mock * Fix Teams docs group chat scope --------- Co-authored-by: openmote[bot] <297980118+openmote[bot]@users.noreply.github.com> Co-authored-by: Matt Rubens <2600+mrubens@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Operators can pin Modal task sandboxes to one or more Modal placement regions via optional deployment-level
MODAL_REGIONS(Settings → Compute advanced field or env var). Roomote passes those regions through on both fresh create and snapshot resume.Why this change was made
Modal already supports region selection on sandbox create, but Roomote never wired it. Without placement control, sandboxes can land in regions where model providers geo-block requests (for example xAI/Grok from EU egress).
Impact
MODAL_REGIONSkeeps Modal’s default placement (no cost multiplier, previous behavior).usorus-westpins new and resumed sandboxes; applies only at spawn time, not to already-running sandboxes.MODAL_ECR_REGION, which only controls ECR image pull authentication.