[Chore] Update fixtures - #232
Merged
Merged
Conversation
Contributor
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Follow-up to #192: replaces the remaining real-world identifiers that sweep missed in five test files with fictional placeholder data, ahead of the repo going public.
packages/github/src/__tests__/task-run-token.test.ts: the multi-repo token test now usesExampleOrg/example-backend/ExampleOrg/example-frontendwithinstall-exampleorg, matching theRoomote/example-app+install-roomoteconvention already used by the neighboring environment test.apps/web/src/app/(onboarding)/setup/StepSourceControlConfig.client.test.tsxandapps/web/src/trpc/commands/github/mutations.test.ts: the GitHub organization fixture is nowexample-org(including thegithub.com/organizations/example-org/settings/apps/newmanifest URL assertion).apps/web/src/lib/server/auth.test.ts:adoOrganizationis nowado-organization, matching the descriptive placeholder style of the surrounding config (ado-client-id,ado-client-secret).apps/web/src/components/layout/side-nav/SideNav.client.test.tsx: theenv-4environment name is nowSandbox.No production code changes; string literals in test fixtures only.
How it was tested
@roomote/github, 38 across the four@roomote/webfiles).pnpm lint:fastandpnpm check-types:fastpass locally; Knip is green in this PR's CI.Checklist
[Fix],[Feat],[Improve],[Refactor],[Docs], or[Chore]followed by a user-facing descriptionpnpm lintandpnpm check-typespass locallypnpm changeset(not needed: test-fixture text only)