You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Both previously flagged issues remain resolved. No new code issues found in the latest changes. See task
Review findings
🔴 apps/controller/src/compute-providers/spawn-docker-worker.ts:196 — Egress policy is not re-applied when a Docker standby container resumes. Resolved by the new restoreDockerStandbyNetworking helper (docker-sandbox-security.ts:312), which re-runs attachDockerEgressPolicy (with blockDockerGateway set from controlNetwork) and is invoked on the resume branch after docker start and before the worker is exec'd (spawn-docker-worker.ts:200).
🟡 apps/controller/src/compute-providers/spawn-docker-worker.ts:142 — Control-plane trusted-service reconnection is skipped on resume. Resolved: restoreDockerStandbyNetworking now calls connectTrustedControlPlaneServices when controlNetwork is set. That helper is idempotent (skips already-attached services and swallows already-connected errors), so recreated api/preview-proxy containers are reconnected on resume without breaking the common still-attached case.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
worker resumeDefaults
0disables its standby retentionConfiguration
DOCKER_STANDBY_MAX_COUNTDOCKER_STANDBY_MAX_AGE_HOURSBLAXEL_STANDBY_MAX_COUNTBLAXEL_STANDBY_MAX_AGE_HOURSValidation
pnpm format:checkpnpm lint:fastpnpm check-types:fastpnpm knip