Skip to content

[Improve] Use a light bulb icon for the Advisor model setting - #196

Merged
mrubens merged 1 commit into
developfrom
improve/advisor-model-lightbulb-icon-0tr713g3dadie
Jul 11, 2026
Merged

[Improve] Use a light bulb icon for the Advisor model setting#196
mrubens merged 1 commit into
developfrom
improve/advisor-model-lightbulb-icon-0tr713g3dadie

Conversation

@roomote-roomote

Copy link
Copy Markdown
Contributor

Opened on behalf of Matt Rubens. Follow up by mentioning @openmote, in the web UI, or in Slack.

Related issue

N/A — internal Roomote UX polish from Slack.

Why this PR exists

  • A maintainer explicitly invited this PR in the linked issue or discussion
  • I am a maintainer / this is internal Roomote work

What changed

On Settings → Models, the Advisor model role now uses a light bulb icon instead of the previous scroll icon.

How it was tested

  • pnpm lint and pnpm --filter @roomote/web check-types
  • Manual browser check on /settings/models after dev login; Advisor row shows the light bulb icon

Screenshots

Advisor model row shows a light bulb icon next to the Advisor model label

Checklist

  • The PR title follows the repo convention: [Fix], [Feat], [Improve], [Refactor], [Docs], or [Chore] followed by a user-facing description
  • This PR is small and scoped to one change
  • pnpm lint and pnpm check-types pass locally
  • I added tests or included a clear manual validation note above
  • I removed secrets, tokens, private keys, and customer data from code, logs, and screenshots
  • If this change should appear in the changelog, I ran pnpm changeset

@roomote-roomote

roomote-roomote Bot commented Jul 11, 2026

Copy link
Copy Markdown
Contributor Author

No code issues found. See task

Reviewed the icon swap on apps/web/src/components/settings/ModelSettingsSection.tsx: Lightbulb replaces ScrollText for the Advisor model role. The Lightbulb icon is exported from the shared icons module, the import stays alphabetically ordered, and ScrollText is still used by other components so removing the unused import here is safe. No functional, type, or correctness concerns.

@mrubens
mrubens marked this pull request as ready for review July 11, 2026 16:31
@mrubens
mrubens merged commit 88ccfb8 into develop Jul 11, 2026
1 check passed
@mrubens
mrubens deleted the improve/advisor-model-lightbulb-icon-0tr713g3dadie branch July 12, 2026 04:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant