[Feat] Make plan mode always on and introduce the Advisor model role with a coding-advisor subagent - #193
Merged
mrubens merged 3 commits intoJul 11, 2026
Conversation
Contributor
Author
|
No new code issues found. See task Re-reviewed the latest update, which removes the
|
mrubens
marked this pull request as ready for review
July 11, 2026 16:10
mrubens
requested review from
brunobergher,
daniel-lxs and
mrubens
as code owners
July 11, 2026 16:10
This was referenced Jul 11, 2026
Merged
mrubens
deleted the
feature/advisor-model-plan-mode-default-3rx2o4qthw03p
branch
July 12, 2026 04:19
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
PlanModefeature flag has been removed entirely (enum entry, config registry, metadata typing, worker flag evaluation, theROOMOTE_PLAN_MODEenv plumbing, and the harness gating), following the same graduation pattern asPrReviewNotifications. Plan-mode turns now switch onto the read-mostlyarchitectagent whenever the planning workflow skill is active, with no per-deployment toggle.models.mdx,environment-variables.mdx) all use "Advisor model" now. Internal identifiers and theR_PLANNING_MODEL/R_PLANNING_MODEL_REASONING_EFFORTenv vars are intentionally unchanged, so existing configuration keeps working and the planning workflow (architect agent) keeps using the same model wiring.advisorsubagent for coding tasks. Every generated OpenCode config now registers a visible (non-hidden)advisorsubagent, and the parent coding agent gets instructions to consult it when it is stuck: repeated failed attempts, confusing bugs, or uncertain approach/design decisions. The advisor uses the configured Advisor model when one is set, and otherwise defaults to the active coding model running at the advisor reasoning level (which defaults tohigh, vs.mediumfor ordinary coding turns). It is read-only (no edit/bash/task) with webfetch allowed, and excludes Slack-posting tools like the other subagents.A changeset is included since this is user-facing.
How it was tested
pnpm lint,pnpm check-types, andpnpm --filter @roomote/docs checkpass; feature-flags, SDK feature-flag router, worker bootstrap/harness/run-task suites (133 tests), and the affected web test suites all pass.Screenshots
Checklist
[Fix],[Feat],[Improve],[Refactor],[Docs], or[Chore]followed by a user-facing descriptionpnpm lintandpnpm check-typespass locallypnpm changeset