[Refactor] Unify Roomote GitHub bot-identity helpers - #177
Merged
mrubens merged 1 commit intoJul 11, 2026
Merged
Conversation
Share the Roomote login identity rules so reviewer allowlists, webhooks, and workflow comment scans cannot drift.
Contributor
Author
|
No code issues found. See task |
mrubens
approved these changes
Jul 11, 2026
mrubens
marked this pull request as ready for review
July 11, 2026 06:42
mrubens
deleted the
refactor/unify-github-bot-identity-helpers-11untg4lgsq0k
branch
July 11, 2026 06:42
This was referenced Jul 11, 2026
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Important
Roomote does not generally accept unsolicited community pull requests. Unless a maintainer invited this PR in an issue or discussion, it will likely be closed without review. A well-written issue is the best way to contribute.
Related issue
Internal Roomote maintenance (no public issue). Collapsing partially divergent GitHub bot-identity helpers left behind after database-configured app slug support.
Why this PR exists
Reviewer/automation managed logins, cloud-agent issue-comment author checks, and runtime
@roomote/githubidentity checks no longer shared one policy, so deployments could recognize bot logins inconsistently (especiallyroomote-dev, custom configured slugs, androomote-*prefix forms).What changed
roomote,roomote-dev) plus configured slug; exact managed-login list for finite allowlists; full match helper that also accepts openroomote-*/app/roomote-*formsisRoomoteGitHubLoginis a thin wrapper over that policy using the effective app slugNo intended user-facing product change. Allowlist generation now also includes hosted
roomote-devexact logins so it stays aligned with identity checks.How it was tested
roomote-dev, prefix forms, and exact managed loginspnpm lintandpnpm check-typespassedChecklist
[Fix],[Feat],[Improve],[Refactor],[Docs], or[Chore]followed by a user-facing descriptionpnpm lintandpnpm check-typespass locallypnpm changeset