[Fix] Surface worker provisioning progress and failures on Settings > Sandboxes - #175
Merged
Merged
Conversation
… Sandboxes The settings page already received the detached provisioning state and polled while a run was building, but rendered it as a generic "Saving..." spinner and never displayed a failed run at all — an operator saving a Daytona key with insufficient permissions saw the save succeed and nothing else, while the registration died with "Access denied" server-side. Match the setup wizard's presentation: label the button "Provisioning..." during the run with a note that it can take a few minutes, show the persisted error inline after a failure, and offer "Retry provisioning" when credentials are already satisfied.
Contributor
|
No code issues found. See task Reviewed this presentation-only change: the button now reads |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Settings → Sandboxes already receives the detached worker base-image provisioning state and polls while a run is building, but presents none of it:
Access denied— the only evidence was in the web service logs.Change
ComputeProviderSectionnow matches the wizard's presentation:provisioning.status === 'building', with a note that the run can take a few minutes.No data-flow changes — the page already polled and passed
provisioning; this is presentation only.Testing
ComputeProviderSection.client.test.tsxcovering the building, failed-with-error, failed-without-error, and idle states.pnpm lint:fast,pnpm check-types:fast,pnpm knipall pass.