Skip to content

[Fix] Home sandbox dropdown shows unconfigured providers - #171

Merged
mrubens merged 2 commits into
developfrom
fix/hide-unconfigured-sandboxes-1c93wkef9q0qv
Jul 11, 2026
Merged

[Fix] Home sandbox dropdown shows unconfigured providers#171
mrubens merged 2 commits into
developfrom
fix/hide-unconfigured-sandboxes-1c93wkef9q0qv

Conversation

@roomote-roomote

@roomote-roomote roomote-roomote Bot commented Jul 11, 2026

Copy link
Copy Markdown
Contributor

Opened on behalf of Matt Rubens. Follow up by mentioning @openmote, in the web UI, or in Slack.

Related issue

N/A — internal Roomote product fix from Slack.

Why this PR exists

  • A maintainer explicitly invited this PR in the linked issue or discussion
  • I am a maintainer / this is internal Roomote work

What changed

The home Sandbox provider dropdown no longer lists unconfigured providers. The home page loads configured sandboxes server-side and only offers those options.

Follow-up: when the saved default is missing from that list, the pre-selected provider now follows the same setup-catalog display order as the dropdown (instead of the raw compute-provider IDs order).

How it was tested

  • Unit tests for configured-provider listing, including catalog display order
  • Home unit tests for filtered providers and catalog-ordered fallback selection
  • pnpm lint and pnpm check-types

Screenshots

Authenticated home with Sandbox provider selected

Open Sandbox provider dropdown listing only Local Docker

Checklist

  • The PR title follows the repo convention: [Fix], [Feat], [Improve], [Refactor], [Docs], or [Chore] followed by a user-facing description
  • This PR is small and scoped to one change
  • pnpm lint and pnpm check-types pass locally
  • I added tests or included a clear manual validation note above
  • I removed secrets, tokens, private keys, and customer data from code, logs, and screenshots
  • If this change should appear in the changelog, I ran pnpm changeset

@roomote-roomote

roomote-roomote Bot commented Jul 11, 2026

Copy link
Copy Markdown
Contributor Author

Re-reviewed the latest change. No new code issues found — the SETUP_COMPUTE_PROVIDER_CATALOG-ordered listing and Home filtering keep the fallback aligned with the first visible dropdown row, and the delta tests pass. See task

  • Low — Home fallback vs dropdown order: fixed by returning configured providers in SETUP_COMPUTE_PROVIDER_CATALOG order and filtering available options through that same order on Home.

@mrubens
mrubens marked this pull request as ready for review July 11, 2026 05:52
@mrubens
mrubens merged commit fcc6806 into develop Jul 11, 2026
1 check passed
@mrubens
mrubens deleted the fix/hide-unconfigured-sandboxes-1c93wkef9q0qv branch July 11, 2026 05:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant