Skip to content

[Fix] Creating a GitHub App fails with merge_group permission error - #165

Merged
mrubens merged 1 commit into
developfrom
fix/github-app-manifest-merge-group-2p6dfj6tnfcy3
Jul 11, 2026
Merged

[Fix] Creating a GitHub App fails with merge_group permission error#165
mrubens merged 1 commit into
developfrom
fix/github-app-manifest-merge-group-2p6dfj6tnfcy3

Conversation

@roomote-roomote

Copy link
Copy Markdown
Contributor

Opened on behalf of Matt Rubens. Follow up by mentioning @openmote, in the web UI, or in Slack.

Related issue

N/A — fix reported while going through the GitHub App create-manifest flow.

Why this PR exists

  • I am a maintainer / this is internal Roomote work

What changed

Creating a GitHub App through Roomote's manifest flow failed on GitHub with:

Default events are not supported by permissions: merge_group

The create-app manifest subscribed to merge_group without requesting the matching merge_queues repository permission that GitHub requires for that event. New apps now request merge_queues: read so the events and permissions stay aligned and the flow can complete.

How it was tested

  • Updated and ran apps/web/src/trpc/commands/github/mutations.test.ts (11 passed)
  • pnpm lint and web typecheck passed

Checklist

  • The PR title follows the repo convention: [Fix], [Feat], [Improve], [Refactor], [Docs], or [Chore] followed by a user-facing description
  • This PR is small and scoped to one change
  • pnpm lint and pnpm check-types pass locally
  • I added tests or included a clear manual validation note above
  • I removed secrets, tokens, private keys, and customer data from code, logs, and screenshots
  • If this change should appear in the changelog, I ran pnpm changeset

Subscribe to merge_group only when the matching merge queues permission is also requested so GitHub accepts the create-app manifest flow.
@roomote-roomote

roomote-roomote Bot commented Jul 11, 2026

Copy link
Copy Markdown
Contributor Author

No code issues found. See task

Reviewed the GitHub App manifest change that adds merge_queues: 'read' to align with the merge_group default event. The permission is applied consistently to the GitHubAppManifest type, buildGitHubAppManifest(), and the test assertion, and read is the correct access level GitHub requires for the merge_group event. No other manifest definitions need the same update.

@mrubens
mrubens marked this pull request as ready for review July 11, 2026 04:45
@mrubens
mrubens merged commit b9b93c0 into develop Jul 11, 2026
1 check passed
@mrubens
mrubens deleted the fix/github-app-manifest-merge-group-2p6dfj6tnfcy3 branch July 11, 2026 04:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant