[Fix] Creating a GitHub App fails with merge_group permission error - #165
Merged
mrubens merged 1 commit intoJul 11, 2026
Merged
Conversation
Subscribe to merge_group only when the matching merge queues permission is also requested so GitHub accepts the create-app manifest flow.
Contributor
Author
|
No code issues found. See task Reviewed the GitHub App manifest change that adds |
mrubens
marked this pull request as ready for review
July 11, 2026 04:45
mrubens
requested review from
brunobergher,
daniel-lxs and
mrubens
as code owners
July 11, 2026 04:45
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issue
N/A — fix reported while going through the GitHub App create-manifest flow.
Why this PR exists
What changed
Creating a GitHub App through Roomote's manifest flow failed on GitHub with:
The create-app manifest subscribed to
merge_groupwithout requesting the matchingmerge_queuesrepository permission that GitHub requires for that event. New apps now requestmerge_queues: readso the events and permissions stay aligned and the flow can complete.How it was tested
apps/web/src/trpc/commands/github/mutations.test.ts(11 passed)pnpm lintand web typecheck passedChecklist
[Fix],[Feat],[Improve],[Refactor],[Docs], or[Chore]followed by a user-facing descriptionpnpm lintandpnpm check-typespass locallypnpm changeset