Skip to content

[Improve] Group the Users task filter into Users and Automations - #161

Merged
mrubens merged 1 commit into
developfrom
improve/group-users-filter-dropdown-0aldcotku9yf8
Jul 11, 2026
Merged

[Improve] Group the Users task filter into Users and Automations#161
mrubens merged 1 commit into
developfrom
improve/group-users-filter-dropdown-0aldcotku9yf8

Conversation

@roomote-roomote

Copy link
Copy Markdown
Contributor

Opened on behalf of Matt Rubens. Follow up by mentioning @openmote, in the web UI, or in Slack.

Related issue

N/A — internal Roomote work from Slack request.

Why this PR exists

  • I am a maintainer / this is internal Roomote work

What changed

The Users filter dropdown on /tasks now matches the Environment filter pattern:

  • Any User stays at the top
  • Users group for human / external initiators
  • Automations group for automation initiators (section title only; items stay plain labels like "PR Review")

How it was tested

  • Unit: TaskFilters.client.test.tsx covers grouped Users/Automations labels and keeps "Any User"
  • pnpm --filter @roomote/web check-types
  • Pre-push: pnpm lint:fast, pnpm check-types:fast, pnpm knip
  • Manual visual proof on /tasks after dev-login (Automations section omitted when no automation options exist in demo data)

Screenshots

Open Users filter dropdown showing Any User then Users section

Users filter dropdown in page context on /tasks

Checklist

  • The PR title follows the repo convention: [Fix], [Feat], [Improve], [Refactor], [Docs], or [Chore] followed by a user-facing description
  • This PR is small and scoped to one change
  • pnpm lint and pnpm check-types pass locally
  • I added tests or included a clear manual validation note above
  • I removed secrets, tokens, private keys, and customer data from code, logs, and screenshots
  • If this change should appear in the changelog, I ran pnpm changeset

@roomote-roomote

roomote-roomote Bot commented Jul 11, 2026

Copy link
Copy Markdown
Contributor Author

No code issues found. See task

Reviewed the grouped Users/Automations task filter change in TaskFilters.tsx and its test. The grouping via parseCreatorFilterValue correctly routes automation:* values into the Automations section while human and external:* initiators stay under Users, mirroring the existing Environment filter pattern. Section labels render only when their group is non-empty. The added unit test passes.

@mrubens
mrubens marked this pull request as ready for review July 11, 2026 02:52
@mrubens
mrubens merged commit 2f4e7e2 into develop Jul 11, 2026
1 check passed
@mrubens
mrubens deleted the improve/group-users-filter-dropdown-0aldcotku9yf8 branch July 11, 2026 02:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant