Skip to content

[Improve] Name the source-control platform in PR review notifications - #139

Merged
mrubens merged 1 commit into
developfrom
improve/name-scm-platform-in-review-messages-3mf2l9g9x8whm
Jul 10, 2026
Merged

[Improve] Name the source-control platform in PR review notifications#139
mrubens merged 1 commit into
developfrom
improve/name-scm-platform-in-review-messages-3mf2l9g9x8whm

Conversation

@roomote-roomote

Copy link
Copy Markdown
Contributor

Opened on behalf of Matt Rubens. Follow up by mentioning @openmote, in the web UI, or in Slack.

What changed

Self-review follow-up messages now name the source-control platform, so people see wording like “I reviewed … on GitHub” (or GitLab, Gitea, Azure DevOps) instead of only a linked repo/PR reference.

The review-notification triage prompt now receives the provider label and is instructed to include that platform on first-person self-review messages. GitHub review-activity and review-summary enqueues also stamp sourceControlProvider: 'github' so the label is available to triage.

Why this change was made

Those messages could look opaque in chat: a link like owner/repo#123 does not make it obvious which host the review ran on. Spelling the platform in the sentence makes the conversation clearer at a glance.

Impact

After this ships, automated self-review notifications should read more clearly in Slack and other conversation surfaces, for example:

I reviewed RooCodeInc/Roomote#138 on GitHub and found no code issues. …

Third-party reviewer notifications are unchanged and still do not force a platform name. Non-GitHub providers already have provider plumbing if those notification paths are wired later.

Self-review chat messages now say "I reviewed … on GitHub/GitLab/…" so people can tell where the review happened.
@roomote-roomote

roomote-roomote Bot commented Jul 10, 2026

Copy link
Copy Markdown
Contributor Author

No code issues found. See task

Reviewed the provider-label plumbing end to end: GitHub webhook handlers stamp sourceControlProvider: 'github', the enqueue path forwards it onto the queued request, the worker passes it through preparePrReviewNotificationDelivery, and triagePrReviewActivity normalizes it into the prompt label plus the updated self-review system-prompt instructions. Provider fallback stays github, so existing behavior is unchanged. Both updated test suites pass locally.

@mrubens
mrubens marked this pull request as ready for review July 10, 2026 21:45
@mrubens
mrubens merged commit b718324 into develop Jul 10, 2026
1 check passed
@mrubens
mrubens deleted the improve/name-scm-platform-in-review-messages-3mf2l9g9x8whm branch July 12, 2026 04:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants