[Chore] Run the deployment acceptance gate concurrently with image builds - #137
Merged
Conversation
…ilds The gate builds its own local images for the smoke test, so serializing it ahead of the build matrix only added its ~5 minutes to every publish. Gate the publish job instead: builds push untagged per-arch digests, and nothing is consumable until publish assembles the tagged manifests, so a failed gate still prevents any image from shipping. Cuts merge-to-nightly wall clock from ~12 to ~7 minutes.
Contributor
|
No code issues found. See task Reviewed the job-dependency rewiring in
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Merge-to-nightly latency is ~12 minutes plus per-branch queueing: the acceptance gate (~5 min) runs strictly before the build matrix (~5.5 min on the arm64 app critical path), even though the gate builds its own local images for the smoke test and consumes nothing from the build jobs.
Change
buildno longer depends ondeployment-acceptance; the two run concurrently.publishnow depends on[prepare, build, deployment-acceptance].Protection is unchanged: build jobs only push untagged per-arch digests, and nothing is consumable until
publishassembles the tagged manifests — which still cannot happen unless the gate passes. Expected wall clock drops to ~max(gate, builds) + manifests ≈ 7 minutes.docs_onlyskip behavior is unchanged: when the gate is skipped, builds are also skipped by the same condition, sopublishskips exactly as before.