[Fix] Allow unbounded sandbox disk in the deployment smoke test - #132
Merged
Conversation
The sandbox hardening in #109 makes the controller refuse to launch a Docker task when the storage driver cannot enforce the writable-layer quota (--storage-opt size). CI runners use overlay2 without project quotas, so the publish acceptance gate now fails at the Docker task probe before a sandbox is launched. Opt the smoke-test stack into DOCKER_WORKER_ALLOW_UNBOUNDED_DISK=true, the escape hatch #109 shipped for exactly this case. Runners are ephemeral, so an unbounded writable layer carries no host disk-exhaustion risk there, and real deployments keep the fail-closed default.
Contributor
|
No code issues found. See task Reviewed the one-line env addition to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The publish gate for develop failed at Deployment acceptance (amd64): https://github.com/RooCodeInc/Roomote/actions/runs/29121015943/job/86456179496
#109 made the controller fail closed when
--storage-opt sizecannot be enforced. CI runners use overlay2 without project quotas, so the candidate controller refused to launch the smoke test's Docker task probe. PR CI never catches this because it only runsdeployment:validate; the full smoke test runs only in the publish workflow.Fix
Opt the smoke-test env into
DOCKER_WORKER_ALLOW_UNBOUNDED_DISK=true— the escape hatch #109 shipped for exactly this case. Runners are ephemeral, so an unbounded writable layer has no real disk-exhaustion blast radius there. Real deployments keep the fail-closed default (falsein all compose files).The controller still passes the 20g quota first and takes the documented warn-and-retry-without-quota path, so the retry code also gets exercised by the gate.
Verification
bash -non the modified script.docker-compose.prod.yml+docker-compose.ci.yml) with an env file written by the updatedwrite_envand confirmed the controller service resolvesDOCKER_WORKER_ALLOW_UNBOUNDED_DISK: "true"withDOCKER_WORKER_DISK_LIMIT: 20gstill set.