[Fix] Publish GHCR Images fails deployment acceptance without Docker disk quotas - #131
Closed
roomote-roomote[bot] wants to merge 1 commit into
Closed
Conversation
Opt the deployment smoke stack into DOCKER_WORKER_ALLOW_UNBOUNDED_DISK so Publish GHCR Images acceptance can spawn Docker workers when the runner storage driver cannot enforce --storage-opt size, without weakening production fail-closed defaults.
Contributor
Author
|
Reviewed. No blocking issues; 1 low-severity optional suggestion below. See task The fix is coherent:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Deployment acceptance opt-ins to the documented unbounded-disk escape hatch so the Publish GHCR Images gate can still launch Docker workers on acceptance runners. Production compose and env defaults stay fail-closed when storage drivers cannot enforce the writable-layer limit. A deployment-artifact check keeps that CI opt-in from being dropped accidentally.
Why this change was made
After the Docker sandbox hardening in #109, Publish GHCR Images on develop failed Deployment acceptance (amd64) because the CI host storage driver cannot enforce the 20g writable-layer quota. Acceptance never opt-ed into the intended override, so
launch-docker-taskrefused to start workers and image publish stayed blocked.Impact
No product UI change. Deployment acceptance and GHCR publish on develop can proceed again on hosts without quota-capable Docker storage. Self-hosted and production Docker deployments keep the default refuse-unless-explicitly-allowed behavior.