Remove tracked promptfoo eval output from git (release hygiene, finding 15) - #130
Merged
Conversation
The generated eval-followup-results.json (obsolete agent names and prompt transcripts) was tracked because the ignore rule only covered eval-results.json. Broaden the rule to the whole packages/cloud-agents/results/ directory, matching all promptfoo outputPath targets. Flagged as finding 15 (open-source release hygiene) in the pre-release architecture audit.
Contributor
|
No code issues found. See task Verified the removed file ( |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes the tracked generated file
packages/cloud-agents/results/eval-followup-results.json(obsolete agent names and generated prompt transcripts), flagged as finding 15 (open-source release hygiene) in the pre-release architecture audit.packages/cloud-agents/results/eval-followup-results.jsonfrom git.gitignorerule from the single filepackages/cloud-agents/results/eval-results.jsonto the wholepackages/cloud-agents/results/directory. The narrow rule is why this file slipped through: all three promptfoo configs (evals/authorship/promptfooconfig.ts,evals/router/promptfooconfig.ts,evals/router/promptfooconfig.followup.ts) write into./results/, but onlyeval-results.jsonwas ignored.Reference check
The only code reference to the file is the
outputPathinevals/router/promptfooconfig.followup.ts, which writes eval output to that path. It stays as-is: future eval runs will regenerate the file locally, and the directory is now ignored. Nothing reads the file.Validation
pnpm lint:fast✅pnpm check-types:fast✅pnpm knip --no-gitignore✅ (exit 0; plainpnpm knipfails in nested.agents/worktrees/checkouts because knip picks up the parent repo's.gitignore, which ignores the whole worktree — verified byte-identical failure on clean HEAD, and knip passes on the same commit in a normal checkout)