[Fix] Resolve lint and knip failures in automation work items tool - #122
Merged
Conversation
The flatten commit left automationWorkItemObjectSchema as a value used only in a type position and exported AutomationWorkItemToolParams with no external consumers, failing Lint and Knip on develop. Infer the params type directly from the input schema shape and drop the export.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Develop CI (Lint + Knip) has been red since the "Flatten submit_automation_work_items to one work item" commit landed:
automationWorkItemObjectSchemawas a value used only in a type position (@typescript-eslint/no-unused-varsat max-warnings=0)AutomationWorkItemToolParamswas exported with no external consumers (Knip unused-export)Infer the params type directly from the input schema shape via
z.ZodObject<typeof automationWorkItemInputSchema>and drop the export. No runtime change.This also unblocks CI on #119, whose merge-ref checks inherit the develop breakage.
Validation
pnpm --filter @roomote/worker lintpnpm --filter @roomote/worker check-typespnpm knippnpm --filter @roomote/worker exec vitest run src/mcp/roomote-mcp-server/__tests__/automation-work-items-tool-schema.test.ts(6 tests)