[Fix] Log in to GHCR before the deployment acceptance smoke test - #120
Closed
daniel-lxs wants to merge 1 commit into
Closed
[Fix] Log in to GHCR before the deployment acceptance smoke test#120daniel-lxs wants to merge 1 commit into
daniel-lxs wants to merge 1 commit into
Conversation
The deployment-acceptance job pulls baseline images from GHCR (deploy/ci/deployment-smoke.sh) but never authenticates, and the packages are private, so every develop run of Publish GHCR Images has been failing with "unauthorized" at the baseline pull since the smoke test landed. Because build -> publish -> deploy dispatch all chain off this job, the failure also blocks staging deploys. Add the same pinned docker/login-action step the build and publish jobs already use; the job already has packages: read. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Every develop run of Publish GHCR Images has been failing in
Deployment acceptance (amd64)→Exercise deployment lifecycle:deploy/ci/deployment-smoke.shpulls the baseline images from GHCR, but thedeployment-acceptancejob haspackages: readwithout a docker login step, and the packages are private. Thebuildandpublishjobs log in; this job was missed.Because
build→publish→ deploy dispatch allneeds:this job, the failure has also been blocking staging deploys — staging's worker is pinned atdevelop-3f602c68while develop is several commits ahead (including #116, which can't ship until this passes).This is also the exact root cause the ci-failure-triage automation diagnosed in the incident behind #116 — it just couldn't submit the work item.
Change
Add the same pinned
docker/login-actionstep the build/publish jobs already use, before the smoke test.🤖 Generated with Claude Code