[Fix] Publish GHCR Images fails on unauthorized roomote-web:develop pull - #118
Closed
roomote-roomote[bot] wants to merge 1 commit into
Closed
[Fix] Publish GHCR Images fails on unauthorized roomote-web:develop pull#118roomote-roomote[bot] wants to merge 1 commit into
roomote-roomote[bot] wants to merge 1 commit into
Conversation
Deployment acceptance must log in with GITHUB_TOKEN so private package channel tags like roomote-web:develop can be pulled for upgrade checks.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Deployment acceptance on Publish GHCR Images was failing while pulling the previous
developchannel for upgrade validation, with an unauthorized error onroomote-web:develop(and the other newer split app packages). The job already hadpackages: read, but unlike the build and publish jobs it never logged Docker into GHCR beforepnpm deployment:smoke.This change adds the same GHCR Docker login step to the deployment acceptance job so baseline package tags can be pulled with
GITHUB_TOKENbefore the smoke suite runs.Why this change was made
Acceptance gates every develop publish and blocks image builds when it fails. After split service images landed, several package names defaulted to private visibility; anonymous pulls return unauthorized even when the tag exists. Authenticated pulls match the permission the workflow already declares and unblock the gate.
Impact
No product behavior change. Publish GHCR Images on
developshould get past Deployment acceptance baseline pulls and continue into build/publish again. Full smoke still depends on the next germane CI run because Docker is not available in this task environment.