This repository was archived by the owner on May 15, 2026. It is now read-only.
Revert fix: resolve LM Studio context length detection (#5075) - #5083
Merged
Conversation
This reverts commit ac85aa6. - Removed fetchModel() method from LmStudioHandler - Removed models property and dynamic model fetching - Reverted getModel() to return static defaults - Removed tests for fetchModel() functionality - Removed import of getLMStudioModels
|
✅ No security or compliance issues detected. Reviewed everything up to d965a24. Security Overview
Detected Code Changes
Reply to this PR with |
mrubens
approved these changes
Jun 24, 2025
Alorse
pushed a commit
to Alorse/Roo-Code
that referenced
this pull request
Jun 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit ac85aa6 from PR #5076.
Changes Reverted
fetchModel()method fromLmStudioHandlermodelsproperty and dynamic model fetching functionalitygetModel()method to return static defaultsfetchModel()functionalitygetLMStudioModelsFiles Changed
src/api/providers/lm-studio.ts- Reverted to original implementationsrc/api/providers/__tests__/lmstudio.spec.ts- Removed new tests and mocksTesting
This revert restores the LM Studio handler to its previous stable state.
Important
Reverts dynamic model fetching in
LmStudioHandler, restoring static defaults and removing related tests.LmStudioHandlerto use static model defaults ingetModel().fetchModel()method and dynamic model fetching.fetchModel()inlmstudio.spec.ts.lm-studio.ts: RemovesfetchModel()and related imports.lmstudio.spec.ts: Removes tests and mocks forfetchModel().This description was created by
for d965a24. You can customize this summary. It will automatically update as commits are pushed.