Update mstest monorepo#1941
Open
renovate[bot] wants to merge 1 commit into
Open
Conversation
renovate
Bot
added
the
📦 dependencies
SummarySummary
CoverageRocket.Surgery.DependencyInjection.Analyzers - 89%
Rocket.Surgery.DependencyInjection.Extensions - 74.1%
Rocket.Surgery.Extensions - 67.8%
Rocket.Surgery.Extensions.Binding - 64%
Rocket.Surgery.Extensions.Logging - 13.7%
Rocket.Surgery.Reactive.Extensions - 0%
Rocket.Surgery.Reflection.Extensions - 43.6%
TestAssembly - 0%
|
![codacy-production[bot]](https://avatars.githubusercontent.com/in/56611?s=60&v=4){kind=small}
There was a problem hiding this comment.
Pull Request Overview
While the project's quality standards are met according to Codacy, this PR contains a major discrepancy between its description and the implementation. The PR is intended to update 'Microsoft.Testing.Extensions.TrxReport' from 2.1.0 to 2.2.3, but the actual changes update the 'dotnet-coverage' tool instead.
Because the primary acceptance criterion remains unaddressed and an unrequested tool update was performed, this PR should not be merged in its current state. The implementation needs to be aligned with the intended package updates.
About this PR
- The requested update for 'Microsoft.Testing.Extensions.TrxReport' (2.1.0 -> 2.2.3) is entirely missing from the provided file changes.
- The PR description specifies an update for 'Microsoft.Testing.Extensions.TrxReport', but the diff only modifies 'dotnet-coverage'. This creates a disconnect between the recorded intent and the actual changes.
Test suggestions
- Verify that the dotnet-coverage tool at version 18.8.0 is compatible with the existing build/test pipeline
Prompt proposal for missing tests
Consider implementing these tests if applicable:
1. Verify that the dotnet-coverage tool at version 18.8.0 is compatible with the existing build/test pipeline
TIP Improve review quality by adding custom instructions
TIP How was this review? Give us feedback
| }, | ||
| "dotnet-coverage": { | ||
| "version": "18.5.1", | ||
| "version": "18.8.0", |
There was a problem hiding this comment.
🟡 MEDIUM RISK
The PR description indicates an update for 'Microsoft.Testing.Extensions.TrxReport' to version 2.2.3, but this line updates 'dotnet-coverage' to 18.8.0. The implementation diverges significantly from the stated intent.
Up to standards ✅🟢 Issues
|
Contributor
Author
Edited/Blocked NotificationRenovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR. You can manually request rebase by checking the rebase/retry box above. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains the following updates:
2.1.0→2.2.3Release Notes
microsoft/testfx (Microsoft.Testing.Extensions.TrxReport)
v2.2.3See release notes here.
v2.2.2See release notes here.
v2.2.1See release notes here.
Configuration
📅 Schedule: (UTC)
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.
This PR was generated by Mend Renovate. View the repository job log.