Skip to content

Chore: Wait subscription to expose message composer#26600

Merged
ggazzo merged 6 commits intodevelopfrom
fix/message-box-intermitence
Aug 17, 2022
Merged

Chore: Wait subscription to expose message composer#26600
ggazzo merged 6 commits intodevelopfrom
fix/message-box-intermitence

Conversation

@ggazzo
Copy link
Member

@ggazzo ggazzo commented Aug 16, 2022

This change should reduce intermittence when opening/sending messages

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

@ggazzo ggazzo requested a review from a team as a code owner August 16, 2022 21:27
@codecov
Copy link

codecov bot commented Aug 16, 2022

Codecov Report

Merging #26600 (69ccee6) into develop (b3bc896) will increase coverage by 0.18%.
The diff coverage is 95.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #26600      +/-   ##
===========================================
+ Coverage    38.47%   38.66%   +0.18%     
===========================================
  Files          758      758              
  Lines        18823    18827       +4     
  Branches      1453     1453              
===========================================
+ Hits          7243     7280      +37     
+ Misses       11363    11329      -34     
- Partials       217      218       +1     
Flag Coverage Δ
e2e 38.66% <95.00%> (+0.18%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@ggazzo ggazzo requested a review from a team as a code owner August 17, 2022 01:48
@ggazzo ggazzo force-pushed the fix/message-box-intermitence branch from 5b4ba3b to 69ccee6 Compare August 17, 2022 04:39
@ggazzo ggazzo merged commit b513c5d into develop Aug 17, 2022
@ggazzo ggazzo deleted the fix/message-box-intermitence branch August 17, 2022 14:20
@ggazzo ggazzo added stat: ready to merge PR tested and approved waiting for merge subj: Testing and removed stat: needs QA labels Aug 17, 2022
gabriellsh added a commit that referenced this pull request Aug 17, 2022
…ove/home

* 'develop' of github.com:RocketChat/Rocket.Chat:
  Chore: Wait subscription to expose message composer (#26600)
csuadev pushed a commit that referenced this pull request Aug 26, 2022
Co-authored-by: Tasso Evangelista <tasso.evangelista@rocket.chat>
@murtaza98 murtaza98 mentioned this pull request Sep 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stat: ready to merge PR tested and approved waiting for merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants