-
Notifications
You must be signed in to change notification settings - Fork 43
[Feature] Create GitHub Issues from Rocket.Chat channels #11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
88cfc1a
Upate Helper Message
samad-yar-khan a9f98c9
Creaet new Issue modal
samad-yar-khan e867069
Add GitHub New Issues Modal
samad-yar-khan dae395f
Add github issue logic
samad-yar-khan 5454148
Add Repository name check
samad-yar-khan 7b9985a
UPdate helper message
samad-yar-khan 873d51e
Change Slash Command, Add Issue Templates
samad-yar-khan a677c84
Update helper message
samad-yar-khan File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Instead of having 7 and 8. Is it possible to have a better user experience of ....
a) logging in within the app settings session
b) from time to time, the app will ask the user to re-enter credential for security
The will gave a better "set and forget" experience to most users. Casual users will never be bothered with logging in and logging out.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Sing-Li We cannot have the login phase in the apps settings session because the app settings are only visible to the users which have
Application Accessgiven by theServer Adminso I don't think it will be convenient.The logout feature will not be used by most users, its just there for convenience incase anyone wants to remove credentials from the server. The Login will be done by the user through the slash command, but they will only be prompted to login while using some feature which requires auth. Apart from that, using
RC Schedulerwe will automatically logout the user periodically and they will be sent a direct message byGitHub App botto login again. It follows the similar workflow as you have mentioned inb), the user does not even have to enter credentials, they will be logged in directly once the click on theloginbutton as the token is regenerated by GitHub. This was suggested by @RonLek to keep the system scalable and not store tokens forever in App Memory. I have added the reasoning behind it in Wiki/Auth.Let me know if I am missing something, maybe we can improve the login user experience in some way, we can discuss this in the upcoming the weekly meeting 😅