Modifies the use of __slots__ for get_fields_and_field_types method#854
Closed
Voldivh wants to merge 2 commits intoRobotWebTools:ros2from
Closed
Modifies the use of __slots__ for get_fields_and_field_types method#854Voldivh wants to merge 2 commits intoRobotWebTools:ros2from
Voldivh wants to merge 2 commits intoRobotWebTools:ros2from
Conversation
Signed-off-by: Voldivh <eloyabmfcv@gmail.com>
Contributor
|
@Voldivh is this PR still relevant? Tests currently do not fail for rolling / iron but maybe none of the existing tests covers that change. Would you mind rebasing such that all CI tests are run again? |
|
This PR has been marked as stale because there has been no activity in the past 6 months. Please add a comment to keep it open. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Public API Changes
None
Description
The attribute
__slots__from a message represents all the attributes from the python class for that message, not only the field names of each component from the message structure. So far, this shouldn't impose any issue, however, taking into account the upcoming modifications from this PR in therosidl_pythonpackage, the current use of the attribute in therosapi/objectutils.pyfile would be affected and therefore, break something.This PR solves that issue by modifying the use of
__slots__for the appropriate method to retrieve the field names and typesget_fields_and_field_types().