Repository navigation
fix(package): ship bundled reference poses in the wheel - #14
Merged
Merged
Conversation
The desktop installer on Linux and macOS installs hhtools from the wheel, and assets/reference_poses lived outside the package, so bundled_reference_bvh_path() returned None for every format. LAFAN calibration then silently fell back to the synthetic bind rest and the hardcoded static reference, which degraded retarget quality compared to a source checkout. Move the zero frame reference files into hhtools/data/reference_poses, declare them as package data, and resolve them relative to the package. The lookup table and fallbacks are unchanged. Add a regression test that every reference resolves inside the installed package and is covered by package data. Signed-off-by: Dundy Pasupuleti <dundysm@gmail.com>
Contributor
Author
|
@Eleanor1018 @jaggerShen ready for a look when you have a moment. This is the wheel packaging fix for #13: reference poses now ship inside the package so the desktop deb matches source/web retargeting for lafan (and soma/mocap/xsens). Includes a regression test that each reference resolves from an installed wheel. Happy to adjust if you'd rather keep the assets/ layout with a build-hook copy instead. |
AIResearcherHZ
pushed a commit
to AIResearcherHZ/human-humanoid-tools
that referenced
this pull request
Oct 16, 2026
…-workbench Feature/consolidated workbench
Contributor
|
@dundysm Pull request have been merged. We will update Linux(deb) and MacOS(dmg) as soon as possible. Thank you very much! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
root cause: the linux and macos desktop installer installs hhtools from the wheel, but
assets/reference_poses/lives outside the package, so it never ships. in a wheel installbundled_reference_bvh_path()returns None for lafan, soma, mocap and xsens. lafan then silently falls back to the synthetic bind rest inbuild_scaler_config_from_calibrationand to the hardcoded static reference in_build_static_lafan. that's why the deb retargets lafan badly while a source build looks right. the windows runtime copies the folder explicitly, so only linux and mac were affected.fix: move the zero frame files to
hhtools/data/reference_poses/, declare them as package data, and resolve them relative to the package. the lookup table, precedence and fallbacks are unchanged.prepare-runtime.mjs, docstrings andmake_reference_pose_bvh.pynow use the new path.test:
tests/retarget/test_bundled_reference_poses.pychecks that every reference resolves inside the installed package, that the package-data globs cover every file, and that the lafan calibration reference loads from the bundled bvh. 5 of its 6 checks fail on main and all pass with this change.verification: the built wheel contains all 5 reference files, and a clean venv install of that wheel resolves all four references plus the lafan 17 joint reference.
alternative: if you'd rather keep the
assets/layout, a setuptools build hook could copy the files into the package at build time instead. happy to switch.Fixes #13
@jaggerShen @Eleanor1018
中文摘要：桌面版通过 wheel 安装时未打包参考姿态文件，导致 LAFAN 校准回退到默认姿态；现将其移入包内并添加回归测试。