Skip to content

Fixed path name issues on windows - #1487

Merged
cyian-1756 merged 1 commit into
RipMeApp:masterfrom
cyian-1756:windows-pathname-fixes
Nov 29, 2019
Merged

cyian-1756 merged 1 commit into
RipMeApp:masterfrom
cyian-1756:windows-pathname-fixes

Conversation

@cyian-1756

Copy link
Copy Markdown
Collaborator

Category

This change is exactly one of the following (please change [ ] to [x]) to indicate which:

Description

Shortens max path name on windows to 259 chars

Testing

Required verification:

  • I've verified that there are no regressions in mvn test (there are no new failures or errors).
  • I've verified that this change works as intended.
    • Downloads all relevant content.
    • Downloads content from multiple pages (as necessary or appropriate).
    • Saves content at reasonable file names (e.g. page titles or content IDs) to help easily browse downloaded content.
  • I've verified that this change did not break existing functionality (especially in the Ripper I modified).

Optional but recommended:

  • I've added a unit test to cover my change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

freezing issue localized and reproducible.

1 participant