perf: walk unedited chunks line by line when generating mappings - #339
Open
Nic-Polumeyv wants to merge 1 commit into
Open
perf: walk unedited chunks line by line when generating mappings#339Nic-Polumeyv wants to merge 1 commit into
Nic-Polumeyv wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Generating mappings for unedited chunks no longer visits every character, which makes
generateMapabout 3x faster on the benchmark (generateMap (no edit)1,912 -> 5,617 hz,generateDecodedMap (edit)2,197 -> 7,354 hz;hires: trueunchanged, it is bound by segment allocation).Without
hiresonly line starts and explicitaddSourcemapLocationpositions produce segments, soaddUneditedChunkjumps between newlines and reads those positions from the BitSet words. Thehiresmodes keep the per-character loop but test word characters by char code instead of a regex. Mappings are byte-identical across the test suite and a comparison harness (CRLF, unicode, empty inputs, every edit method).