feat(observability): name HTTP handlers with Effect.fn spans#882
Draft
RhysSullivan wants to merge 1 commit into
Draft
feat(observability): name HTTP handlers with Effect.fn spans#882RhysSullivan wants to merge 1 commit into
RhysSullivan wants to merge 1 commit into
Conversation
Convert all 68 HttpApiBuilder handlers across core/api, the source plugins
(mcp/graphql/openapi/onepassword), host-selfhost, and cloud from inline
`(args) => Effect.gen(...)` to named `Effect.fn("group.endpoint")(function* (ctx) {...})`.
Each endpoint now opens a named trace span + fiber.
Input types don't infer through Effect.fn, so each handler's `ctx` is annotated
from the endpoint contract; a few contract body/param schemas gained `export` to
support `typeof X.Type`. Pure span-naming refactor — no behaviour change.
Verified: typecheck (all 38 packages), lint (0/0, require-effect-fn-name), format,
and api/cloud/plugin/host-selfhost test suites.
Deploying with
|
| Status | Name | Latest Commit | Updated (UTC) |
|---|---|---|---|
| ✅ Deployment successful! View logs |
executor-cloud | 4f927c4 | Jun 02 2026, 05:31 PM |
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
executor-marketing | 4f927c4 | Commit Preview URL Branch Preview URL |
Jun 02 2026, 05:30 PM |
@executor-js/cli
@executor-js/config
@executor-js/execution
@executor-js/sdk
@executor-js/codemode-core
@executor-js/runtime-quickjs
@executor-js/plugin-file-secrets
@executor-js/plugin-graphql
@executor-js/plugin-keychain
@executor-js/plugin-mcp
@executor-js/plugin-onepassword
@executor-js/plugin-openapi
executor
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Names every HTTP endpoint with a trace span.
Converts all 68
HttpApiBuilderhandlers acrosscore/api, the source plugins (mcp/graphql/openapi/onepassword),host-selfhost, andcloudfrom inline(args) => Effect.gen(...)to namedEffect.fn("group.endpoint")(function* (ctx) {...}). Each endpoint now opens a named trace span + fiber — e.g.connections.list,secrets.set,sources.refresh,cloudAuth.me.Input types don't infer through
Effect.fn, so each handler'sctxis annotated from the endpoint contract; a few contract body/param schemas gainedexportto supporttypeof X.Type. Pure span-naming refactor — no behaviour change.Stacked on #881.
Verified: typecheck (all 38 packages), lint (0/0,
require-effect-fn-name), format, andapi/cloud/plugin/host-selfhosttest suites.Draft — changeset + full e2e to come.