Skip to content

AB#139370: Improve UX/UI of emails - #2950

Open
Joselgc1 wants to merge 10 commits into
nextfrom
AB#139370
Open

Joselgc1 wants to merge 10 commits into
nextfrom
AB#139370

Conversation

@Joselgc1

@Joselgc1 Joselgc1 commented Oct 1, 2026

Copy link
Copy Markdown
Contributor

Description

Improves email notification performance, reliability, configuration clarity, and list visibility.

Key changes:

  1. Optimized grid email queries to fetch only required templates and distribution lists.
  2. Fixed email notification editing becoming locked after dataset validation failures.
  3. Added a UTC notice to email scheduling.
  4. Added notification status indicators for Draft and Active notifications.
  5. Added Configured by and Last execution (UTC) columns.
  6. Improved language options to show the current-language and native names.
  7. Fixed TypeScript and Jest configuration for email-function spec files.
  8. Added accessible help tooltips to unclear notification options.
  9. Replaced the redundant Type column with Manual and Scheduled delivery indicators.

Useful links

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Improvement (refactor or addition to existing functionality)

How Has This Been Tested?

  • Ran focused frontend unit tests covering email editing, scheduling, statuses, delivery modes, language labels, tooltips, and dataset behavior.
  • Ran Angular template compilation with npx ngc -p libs/shared/tsconfig.lib.json --noEmit.
  • Ran ESLint, Prettier, translation validation, and git diff --check.
  • Ran backend tests for filtered template queries and notification proxy errors.
  • Ran all email-function tests: 18 suites and 167 tests passed.
  • Ran the email-function production build and test TypeScript check.

Screenshots

  1. Only selected templates and distribution-list are retrieved
image image
  1. Email list with Status, Delivery, Configured by, and Last execution columns.
image
  1. Notification language selector and help icon.
image image
  1. Separate-email option tooltips.
image image image
  1. Scheduling UTC notice and help tooltip.
image image

Checklist:

( * == Mandatory )

  • * I have set myself as assignee of the pull request
  • * My code follows the style guidelines of this project
  • * Linting does not generate new warnings
  • * I have performed a self-review of my own code
  • * I have put the ticket for review, adding the oort-frontend team to the list of reviewers
  • * I have commented my code, particularly in hard-to-understand areas
  • * I have put JSDoc comment in all required places
  • * My changes generate no new warnings
  • * I have included screenshots describing my changes if relevant
  • * I have selected labels in the Pull Request, according to the changes with code brings
  • I have made corresponding changes to the documentation (if required)
  • I have added tests that prove my fixes and improvements are effective
  • New and existing relevant unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@Joselgc1
Joselgc1 requested a review from AntoineRelief October 1, 2026 09:09

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant