refactor(core): add createElement helper APIs and reuse them in rules - #1937
Merged
Conversation
- add create-element module with getCreateElementTypeArgument, getCreateElementPropsObject, getCreateElementChildrenArguments, getCreateElementProp, isCreateElementChildrenArgument and isInsideCreateElementProps - replace dual from @local/eff with hand-rolled overloads in api.ts - reuse the new helpers in no-children-prop, no-children-prop-with-children, no-array-index-key and no-nested-component-definitions, dropping duplicated local utils
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update "[ ]" to "[x]" to check a box
What kind of change does this PR introduce?
Check at least one. If you are introducing a new binding, you must reference an issue where this binding has been proposed, discussed and approved by the maintainers.
Does this PR introduce a breaking change?
If yes, please describe the impact and migration path for existing applications in an attached issue.
Checklist
fix: remove a typo, closes #___, #___)Other information
create-elementmodule to@eslint-react/corewithgetCreateElementTypeArgument,getCreateElementPropsObject,getCreateElementChildrenArguments,getCreateElementProp,isCreateElementChildrenArgumentandisInsideCreateElementProps, plus tests and generated docs.dualfrom@local/effwith hand-rolled overloads inapi.ts, preserving both the direct and curried call signatures (including theisAPICalltype guard).no-children-prop,no-children-prop-with-children,no-array-index-keyandno-nested-component-definitions, dropping the duplicatedfind-create-element-children-proputil and the localisInsideCreateElementProps.no-array-index-keynow also inspectscreateElementprops wrapped in type expressions (e.g.{ key: i } as const) viagetCreateElementPropsObject;cloneElementhandling is unchanged.