added limitedBox extension#72
Merged
ReinBentdal merged 2 commits intoReinBentdal:masterfrom Feb 16, 2022
chomosuke:addLimited
Merged
added limitedBox extension#72ReinBentdal merged 2 commits intoReinBentdal:masterfrom chomosuke:addLimited
ReinBentdal merged 2 commits intoReinBentdal:masterfrom
chomosuke:addLimited
Conversation
Owner
|
Thanks for your contribution! Could you also remove the examples/pubspec.lock file from the repository to match changes in gitignore? |
Contributor
Author
|
Hi, changes in gitignore does not actually ignore examples/pubspec.lock file. Furthermore, I don't think examples/pubspec.lock file should be removed. examples is a project and should probably have its pubspec committed to git. |
Owner
|
either way it's not a big deal. Accepts PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First of all, thank you for making this wonderful library. It improves my code significantly.
I've removed the pubspec.lock file as per flutter guideline.
I've also made a lot of changes by auto formatting on save. I can remove them if you dislike it.