Skip to content

fix character handling in params #84

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gkorland merged 3 commits into from
Oct 18, 2020
+5 −2
Merged

fix character handling in params #84

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0f74044
fix charecter handling in params
Oct 12, 2020
adf34df
added char test
Oct 13, 2020
700162e
Merge branch 'master' into fix_char_param_process
Oct 18, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions src/main/java/com/redislabs/redisgraph/impl/Utils.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,6 +99,9 @@ private static String valueToString(Object value) {
if(String.class.isInstance(value)){
return quoteString((String) value);
}
if(Character.class.isInstance((value))){
return quoteString(((Character)value).toString());
}

if(value.getClass().isArray()){
return arrayToString((Object[]) value);
Expand Down
4 changes: 2 additions & 2 deletions src/test/java/com/redislabs/redisgraph/RedisGraphAPITest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -879,8 +879,8 @@ public void testPath(){

@Test
public void testParameters(){
Object[] parameters = {1, 2.3, true, false, null, "str", Arrays.asList(1,2,3), new Integer[]{1,2,3}};
Object[] expected_anwsers = {1L, 2.3, true, false, null, "str", Arrays.asList(1L, 2L, 3L), new Long[]{1L, 2L, 3L}};
Object[] parameters = {1, 2.3, true, false, null, "str", 'a', "b" ,Arrays.asList(1,2,3), new Integer[]{1,2,3}};
Object[] expected_anwsers = {1L, 2.3, true, false, null, "str", "a", "b", Arrays.asList(1L, 2L, 3L), new Long[]{1L, 2L, 3L}};
Comment thread
gkorland marked this conversation as resolved.
Map<String, Object> params = new HashMap<>();
for (int i=0; i < parameters.length; i++) {
Object param = parameters[i];
Expand Down