Support (Geo) Point datatype#112
Merged
sazzad16 merged 13 commits intoRedisGraph:masterfrom Jul 29, 2021
Merged
Conversation
gkorland
suggested changes
Apr 14, 2021
Contributor
gkorland
left a comment
gkorland
left a comment
There was a problem hiding this comment.
Please cover the toString and hash Point functions
Contributor
|
This pull request introduces 1 alert when merging cd3ea1d into d84af9a - view on LGTM.com new alerts:
|
This reverts commit 629500d.
gkorland
previously approved these changes
Apr 21, 2021
Conflicts: src/test/java/com/redislabs/redisgraph/RedisGraphAPITest.java
sazzad16
commented
Apr 22, 2021
DvirDukhan
reviewed
Apr 27, 2021
Comment on lines
+49
to
+50
| return Math.abs(latitude - o.latitude) < EPSILON && | ||
| Math.abs(longitude - o.longitude) < EPSILON; |
Contributor
There was a problem hiding this comment.
I think we should find the mapping format (datum) resolution and infer EPSILON from it, otherwise, we can get wrong results here
Contributor
Author
There was a problem hiding this comment.
@DvirDukhan I'd prefer to avoid that. The difference is already very low and datum resolution would just bring more precision issue. More importantly, we are not calculating the distance here. We are just trying to check if the latitudes and longitudes (both plural) can be considered same.
Contributor
|
@gkorland I'll be happy to review if you guys are backed up. |
gkorland
approved these changes
Jul 29, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #111