chore: recreate a fresh package-lock.json to handle more CVEs - #597
Merged
Conversation
|
Review changes with |
Contributor
|
joanise
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Goal?
npm audit fixis breaking too many things. Instead, for this PR, I deleted mynode_modulesfolder and thepackage-lock.jsonfile and created it all again with a freshnpm install, using npm 12.0.1 and node 24.18.0Fixes?
The entanglement of our dependencies over repeated version bumps on the same lock file.
Feedback sought?
sanity checking
Priority?
medium high due to the quite a few outstanding vulnerability reports
Tests added?
n/a
How to test?
standard way to test stuff, covered in CI and the PR preview
Confidence?
high
Version change?
no