Adding test blocks into the playground - #1629
Merged
AnmAtAnm merged 3 commits intoFeb 16, 2018
Merged
Conversation
The new toolbox option includes a number of test blocks largely pulled from the android project, testing various configurations and edge cases.
3 tasks
picklesrus
reviewed
Feb 16, 2018
| }, | ||
| { | ||
| "type": "field_image", | ||
| "src": "https://blockly-demo.appspot.com/static/media/test_a.png", |
Contributor
There was a problem hiding this comment.
can these use the media url thingy?
Contributor
There was a problem hiding this comment.
Doh. never mind. I now realize getting them off the network was the whole point of this block :)
picklesrus
reviewed
Feb 16, 2018
picklesrus
left a comment
Contributor
There was a problem hiding this comment.
Did you make the images?
Please ignore my other comment :)
Contributor
Author
|
I made the letter images. The LED icon I pulled as creative commons. Imagess on Android repo:
Block definitions: |
Contributor
|
LGTM |
Contributor
Author
|
Travis failure unrelated to code: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The basics
The details
Resolves
#1626
Adds a number of test blocks to the playground for testing block configurations (and edge cases) not covered by the standard blocks.
Proposed Changes
Adds a new toolbox option to the playground, which includes only test blocks.
Does not change the blocks shown in other toolbox configurations.
Blocks include:
Reason for Changes
Provides an easy way to test these cases, encouraging more regular spot testing.
Test Coverage
Test blocks in this PR reference some network images that are not yet online. However, I tested them with URLs from the android project before setting them up with blockly-demo URL.
Tested on:
Additional Information