Remove forceRerender() from FieldDropDown. - #1611
Merged
rachel-fenichel merged 1 commit intoFeb 14, 2018
Merged
Conversation
Errantly forced whole block to rerender, including fields that had not yet been initialized. Fixes RaspberryPiFoundation#1609
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(Cherry-pick #1610 into release candidate.)
The basics
The details
Resolves
#1609 Uncaught TypeError: Cannot read property 'firstChild' of undefined
Proposed Changes
Do not render block during field init().
Reason for Changes
The forced block render was causing other fields to render before they initialized, and fail.
Test Coverage
Manually tested all dropdown blocks and reported block in both LTR and RTL:
Also verified proper resize on variable rename (since variable fields are also dropdowns).
Tested on: