Bugfix/1600 - #1605
Merged
rachel-fenichel merged 3 commits intoFeb 13, 2018
Merged
Conversation
AnmAtAnm
approved these changes
Feb 13, 2018
AnmAtAnm
left a comment
AnmAtAnm
left a comment
Contributor
There was a problem hiding this comment.
Approve after minor corrections.
| <category name="Functions" colour="290" custom="PROCEDURE"></category> | ||
| </xml> | ||
|
|
||
| <!-- toolbox-categories-untyped-variables has a category menu and an |
| return document.getElementById('toolbox-' + (match ? match[1] : 'categories')); | ||
| // Default to the basic toolbox with categories and untyped variables, | ||
| // but override that if the toolbox type is set in the URL. | ||
| var toolboxSuffix = (match ? match[1] : 'categories'); |
Contributor
There was a problem hiding this comment.
'categories' should be 'toolbox-categories', right?
Collaborator
Author
There was a problem hiding this comment.
No, because it's a suffix. It's added to 'toolbox-' on line 150.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The basics
The details
Resolves
Fix #1600
Proposed Changes
Add a new option to the "simple/categories" toolbox dropdown in the playground. The options are now "Categories (typed variables)", "Categories (untyped variables)", and "Simple".
I did this by adding a new chunk of XML because I want to keep the sample XML in the playground as simple as possible, such that someone can just copy the sample XML to get started. A shorter way would have been to dynamically change the XML, but that would have spread the construction of the toolbox XML more than I want.
I added some comments to explain what each chunk of XML means, and links to the documentation for first-time developers who are looking through the playground code as a starting point.
Reason for Changes
Mixing the typed and untyped variable blocks in the playground was confusing.
Test Coverage
The playground still works. I can open all three types of toolbox, by using the dropdown or by changing the URL. The variable categories both open.
Tested on:
Additional Information
In the second commit I cleaned up some indentation in the toolbox options struct.