Warn conflicts with Blockly.Generator.prototype - #1603
Merged
AnmAtAnm merged 4 commits intoFeb 12, 2018
Conversation
…enerator.prototype.
| Blockly.Block = function(workspace, prototypeName, opt_id) { | ||
| if (typeof Blockly.Generator.prototype[prototypeName] !== 'undefined') { | ||
| console.warn('FUTURE ERROR: Block prototypeName "' + prototypeName | ||
| + '`" conflicts with Blockly.Generator members. Registering Generators ' |
Collaborator
There was a problem hiding this comment.
There's an extra ` here that doesn't match the rest of your quote.
rachel-fenichel
approved these changes
Feb 12, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Console warnings on block prototypeNames that conflict with Blockly.Generator.prototype
First pass at #1558
The basics
The details
Resolves
Warning on conflicting Block names. Implementing a warning first, since fully banning type names is a breaking change.
Proposed Changes
Warn on conflict with Blockly.Generator.prototype members.
Reason for Changes
By convention, we use the Generator instance objects as generator function maps. This will conflict with prototype lookup for name collisions between block names and said members, and needs to be disallowed. However, this is a breaking changes, so emit a warning in this release.
Test Coverage
Locally edited Playground test blocks to have conflicting block instances. Saw the expected the error.
Also ran the build script with no bad effect on existing demos.