VarCreate bugfix - #1477
Merged
rachel-fenichel merged 6 commits intoNov 22, 2017
Merged
Conversation
…th pre-existing variables from the flyout into the workspace.
…eate gets fired when a block with a new default variable is dragged out into the workspace.
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
| Blockly.Events.enable(); | ||
| } | ||
|
|
||
| var variablesAfterCreation = this.targetWorkspace_.getAllVariables(); |
Collaborator
There was a problem hiding this comment.
Make this into a helper function: Blockly.Flyout.prototype.getAddedVariables(variablesBeforeCreation) that returns the list of new variables.
Contributor
Author
|
I signed it! |
|
CLAs look good, thanks! |
…les into a helper function.
| * Helper function to get the list of variables that have been added to the | ||
| * workspace after adding a new block, using the given list of variables that | ||
| * were in the workspace before the new block was added. | ||
| * @param {!Array.<Blockly.VariableModel>} originalVariables The array of |
Collaborator
There was a problem hiding this comment.
!Array.<!Blockly.VariableModel>, here and on the return. And then we're done, and I'll merge it as soon as travis finishes!
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The basics
The details
Resolves
Resolves #1395
Proposed Changes
Fixes the bug where VarCreate does not get fired when dragging a block with a variable out into the workspace:
Reason for Changes
Dragging out a block with a variable into the workspace was not issuing a VarCreate event even though a variable was getting added to the workspace.
Test Coverage
Tried steps to reproduce issue #1395 and saw that the VarCreate event is getting fired once for each new variable being added to the workspace. VarCreate event does not retrigger when dragging blocks referring to existing variables out into the workspace.
Tested on:
Additional Information