Converts "fitParams" and "otherParams" to row arrays#301
Converts "fitParams" and "otherParams" to row arrays#301DrPaulSharp merged 1 commit intoRascalSoftware:masterfrom
Conversation
DrPaulSharp
left a comment
There was a problem hiding this comment.
Based on what we've found with this bug, we also need to consider how we test the translation of python to C++ and back, and we need a basic test of "simplex", "de", "ns" and "dream" calculations in the python too - it seems like this bug exposed a seg fault there that has gone unnoticed until now.
|
Yeah, I did have to switch tack on this one to keep things as simple as possible. I'll just go through and verify everything and then update as necessary. |
|
Ok, this PR changes everything to row arrays in the code outside of the minimisers. There are changes to simplex to ensure that the column arrays it uses are transposed to row arrays outside of the minimiser. There are also changes to the other minimisers to make sure that they convert (or not) to row arrays outside of the minimiser, rather than working with columns outside the minimiser as was previously done. Does that cover everything you wanted to know? |
StephenNneji
left a comment
There was a problem hiding this comment.
looks good, sorry for the confusion, I'm probably just recovering from my break 😄
This PR addresses the issue in #299
The previous PR #257 unified the code to use column arrays for
problemStruct.fitParamsfollowing the lead of thepackParamsroutine. However, this bug has arisen because the de and dream algorithms expectfitParamsto take row arrays. However,simplexexpectsfitParamsto take column arrays.The best and least intrusive solution to this is to refactor the code, including
packParams, to use row arrays, with two changes tosimplexto enable it to work correctly.