[rocprofiler-sdk] info log cleanup#7642
Draft
meserve-amd wants to merge 1 commit into
Draft
Conversation
- Demotes several log messages from info to trace level - Removes extra newlines from kfd log messages - Promotes kfd dropped events log message to warning - Sanitizes newline characters on event_str coming from kfd
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
I found the log messages coming from our tests were very crwoded, so I trimmed down some of the worst offenders.
Technical Details
In most cases, there are simple demotions from info to trace for non-exceptional events. kfd.cpp's log messages all also had additional newlines which are not needed in our macro.
The KFD dropped events message is promoted to warning, this shouldn't usually happen.
The KFD event_str sometimes had newline characters in it which would be printed directly. This change makes it so they are printed as byte codes instead.
JIRA ID
Test Plan
Just CI, no new tests added
Test Result
Submission Checklist