Skip to content

Revert "shared memory config in docker run" #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gargrahul merged 1 commit into from
Jul 21, 2025
Merged

Revert "shared memory config in docker run" #21

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 2 additions & 9 deletions src/madengine/tools/run_models.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -634,9 +634,9 @@ def run_model_impl(

if gpu_vendor.find("AMD") != -1:
docker_options = "--network host -u root --group-add video \
--cap-add=SYS_PTRACE --cap-add SYS_ADMIN --device /dev/fuse --security-opt seccomp=unconfined --security-opt apparmor=unconfined "
--cap-add=SYS_PTRACE --cap-add SYS_ADMIN --device /dev/fuse --security-opt seccomp=unconfined --security-opt apparmor=unconfined --ipc=host "
elif gpu_vendor.find("NVIDIA") != -1:
docker_options = "--cap-add=SYS_PTRACE --cap-add SYS_ADMIN --cap-add SYS_NICE --device /dev/fuse --security-opt seccomp=unconfined --security-opt apparmor=unconfined --network host -u root "
docker_options = "--cap-add=SYS_PTRACE --cap-add SYS_ADMIN --cap-add SYS_NICE --device /dev/fuse --security-opt seccomp=unconfined --security-opt apparmor=unconfined --network host -u root --ipc=host "
else:
raise RuntimeError("Unable to determine gpu vendor.")

Expand Down Expand Up @@ -909,13 +909,6 @@ def run_model(self, model_info: typing.Dict) -> bool:
# Environment variable updates for MAD Public CI
run_details.gpu_architecture = self.context.ctx["docker_env_vars"]["MAD_SYSTEM_GPU_ARCHITECTURE"]

# Check the setting of shared memory size
if "SHM_SIZE" in self.context.ctx:
shm_size = self.context.ctx["SHM_SIZE"]
if shm_size:
run_details.additional_docker_run_options += f" --shm-size={shm_size}"
print(f"Using SHM_SIZE from context: {shm_size}")

# Check if model is deprecated
if model_info.get("is_deprecated", False):
print(f"WARNING: Model {model_info['name']} has been deprecated.")
Expand Down