[atom-vllm CI] align the aiter download logic with atom CI#706
Merged
zejunchen-zejun merged 1 commit intoMay 7, 2026
Merged
Conversation
Signed-off-by: zejunchen-zejun <zejun.chen@amd.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the atom-vllm CI workflow to fetch the latest amd_aiter wheel via an S3 “latest main” manifest first, and fall back to downloading the most recent GitHub Actions artifact from ROCm/aiter when the manifest path fails or appears stale—aligning the download behavior with the main ATOM CI.
Changes:
- Add an S3 manifest-based wheel selection/download path with a cache-busting query param.
- Refactor artifact discovery/download into helper functions and broaden artifact name matching to
aiter-whl-*. - Keep exporting
aiter_artifact_id/aiter_wheel_nameoutputs for downstream image labeling/build args.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+130
to
+134
| if find_latest_artifact; then | ||
| if [ -n "$ARTIFACT_RUN_SHA" ] && [ "$manifest_commit" != "$ARTIFACT_RUN_SHA" ]; then | ||
| if [ -n "$ARTIFACT_RUN_CREATED_AT" ] && [[ "$manifest_timestamp" < "$ARTIFACT_RUN_CREATED_AT" ]]; then | ||
| echo "Manifest commit $manifest_commit is older than latest artifact run $ARTIFACT_RUN_ID ($ARTIFACT_RUN_SHA); treating manifest as stale" | ||
| return 1 |
Comment on lines
+71
to
+75
| python3 -c 'import sys | ||
| from urllib.parse import quote, unquote, urlsplit, urlunsplit | ||
| parts = urlsplit(sys.argv[1]) | ||
| encoded_path = "/".join(quote(unquote(segment), safe="") for segment in parts.path.split("/")) | ||
| print(urlunsplit((parts.scheme, parts.netloc, encoded_path, parts.query, parts.fragment)))' "$1" |
valarLip
approved these changes
May 7, 2026
zejunchen-zejun
deleted the
zejun/fix_atom_vllm_ci_aiter_download_logic_0507
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.