update deploy_and_use.md for rh-sre, rh-virt, rh-basic packs - #152
update deploy_and_use.md for rh-sre, rh-virt, rh-basic packs#152operetz-rh wants to merge 1 commit into
Conversation
|
Hi @operetz-rh, Did you check if |
|
The docs must indicate to users how to install the marketplace and the plugin step by step.. Did you also try to follow your own instructions for validation? |
71d5fe4 to
b25e376
Compare
|
Hey @r2dedios, thanks!
please let me know if you recognize any other issue or problems - will fix all :) |
r2dedios
left a comment
There was a problem hiding this comment.
Just a couple of observations to review, but looks promising! 🚀
| - [Claude Code](https://claude.com/product/claude-code) (CLI or IDE extension) | ||
| - [GitHub Copilot](https://github.com/features/copilot) (CLI or VS Code) | ||
| - [Cursor](https://www.cursor.com/) | ||
| - [Gemini CLI](https://github.com/google-gemini/gemini-cli) |
There was a problem hiding this comment.
Gemini CLI it's listed on the supported LLMs for Lola, but @TomerFi noticed that Gemini CLI returns error for that case (Tomer's comment)
By then, I think it's better to remove Gemini CLI by the moment
| - [Claude Code](https://claude.com/product/claude-code) (CLI or IDE extension) | ||
| - [GitHub Copilot](https://github.com/features/copilot) (CLI or VS Code) | ||
| - [Cursor](https://www.cursor.com/) | ||
| - [Gemini CLI](https://github.com/google-gemini/gemini-cli) |
There was a problem hiding this comment.
Same thing as in rh-basic plugin
| - [Claude Code](https://claude.com/product/claude-code) (CLI or IDE extension) | ||
| - [GitHub Copilot](https://github.com/features/copilot) (CLI or VS Code) | ||
| - [Cursor](https://www.cursor.com/) | ||
| - [Gemini CLI](https://github.com/google-gemini/gemini-cli) |
There was a problem hiding this comment.
Same thing as in rh-basic plugin
| ### Installation (Lola) | ||
| ### Step 2: Configure environment variables | ||
|
|
||
| The pack uses MCP servers that require credentials passed as environment variables. **Never hardcode tokens — always use environment variables.** |
There was a problem hiding this comment.
| The pack uses MCP servers that require credentials passed as environment variables. **Never hardcode tokens — always use environment variables.** | |
| The pack uses three MCP servers that require credentials passed as environment variables. **Never hardcode tokens — always use environment variables.** |
The other plugins doc files define how many MCPs are being used. This one just says "uses MCP servers".. It's not an error, but only for consistency, I would add:

Summary
Pack(s) affected
ocp-adminrh-ai-engineerrh-automationrh-basicrh-developerrh-srerh-virtChange type
mcps.json)Contribution method
/agentic-contribution-skillmake validate+make validate-skill-design-changed)Pack-persona alignment (new skills only)
AGENTS.md compliance
${VAR}referencesValidation
make validatepasses locallyname,description)name,description)