Skip to content

update deploy_and_use.md for rh-sre, rh-virt, rh-basic packs - #152

Open
operetz-rh wants to merge 1 commit into
mainfrom
docs/update-deploy-and-use-instructions
Open

update deploy_and_use.md for rh-sre, rh-virt, rh-basic packs#152
operetz-rh wants to merge 1 commit into
mainfrom
docs/update-deploy-and-use-instructions

Conversation

@operetz-rh

@operetz-rh operetz-rh commented Aug 18, 2026

Copy link
Copy Markdown
Contributor

Summary

Pack(s) affected

  • ocp-admin
  • rh-ai-engineer
  • rh-automation
  • rh-basic
  • rh-developer
  • rh-sre
  • rh-virt
  • Other / repo-wide

Change type

  • New skill
  • New agent
  • New pack
  • Update existing skill / agent
  • MCP server config (mcps.json)
  • Docs / README
  • CI / tooling

Contribution method

  • Created/imported with /agentic-contribution-skill
  • Manual contribution (validated with make validate + make validate-skill-design-changed)

Pack-persona alignment (new skills only)

AGENTS.md compliance

  • Agents orchestrate skills; no direct MCP/tool calls in agents
  • Skills are single-purpose task executors
  • Skills encapsulate all tool access (MCP tools invoked only inside skills)
  • Document consultation: file is read with the Read tool, then declared to the user
  • No credentials hardcoded; env vars used via ${VAR} references
  • Human-in-the-loop confirmation added for any destructive or critical operations

Validation

  • make validate passes locally
  • New/changed skills have valid YAML frontmatter (name, description)
  • New/changed agents have valid YAML frontmatter (name, description)

@operetz-rh operetz-rh self-assigned this Aug 18, 2026
@operetz-rh
operetz-rh marked this pull request as ready for review August 18, 2026 12:47
@r2dedios r2dedios added the documentation Improvements or additions to documentation label Aug 18, 2026
@r2dedios

r2dedios commented Aug 19, 2026

Copy link
Copy Markdown
Contributor

Hi @operetz-rh, Did you check if make generate on the agentic-catalog repo works correctly with these new changes?

@r2dedios

Copy link
Copy Markdown
Contributor

The docs must indicate to users how to install the marketplace and the plugin step by step.. Did you also try to follow your own instructions for validation?

@operetz-rh
operetz-rh marked this pull request as draft August 20, 2026 08:01
@operetz-rh
operetz-rh force-pushed the docs/update-deploy-and-use-instructions branch from 71d5fe4 to b25e376 Compare August 20, 2026 08:01
@operetz-rh

Copy link
Copy Markdown
Contributor Author

Hey @r2dedios, thanks!

  • Have tested the process step by step (lola install, skill counts, names etc.)
  • Ran make generate in agentic catalog project - the content works - issue with display (opened fix in PR)
  • Adding picture of local run for example

please let me know if you recognize any other issue or problems - will fix all :)
image

@r2dedios r2dedios left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple of observations to review, but looks promising! 🚀

- [Claude Code](https://claude.com/product/claude-code) (CLI or IDE extension)
- [GitHub Copilot](https://github.com/features/copilot) (CLI or VS Code)
- [Cursor](https://www.cursor.com/)
- [Gemini CLI](https://github.com/google-gemini/gemini-cli)

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gemini CLI it's listed on the supported LLMs for Lola, but @TomerFi noticed that Gemini CLI returns error for that case (Tomer's comment)

By then, I think it's better to remove Gemini CLI by the moment

- [Claude Code](https://claude.com/product/claude-code) (CLI or IDE extension)
- [GitHub Copilot](https://github.com/features/copilot) (CLI or VS Code)
- [Cursor](https://www.cursor.com/)
- [Gemini CLI](https://github.com/google-gemini/gemini-cli)

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same thing as in rh-basic plugin

- [Claude Code](https://claude.com/product/claude-code) (CLI or IDE extension)
- [GitHub Copilot](https://github.com/features/copilot) (CLI or VS Code)
- [Cursor](https://www.cursor.com/)
- [Gemini CLI](https://github.com/google-gemini/gemini-cli)

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same thing as in rh-basic plugin

### Installation (Lola)
### Step 2: Configure environment variables

The pack uses MCP servers that require credentials passed as environment variables. **Never hardcode tokens — always use environment variables.**

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
The pack uses MCP servers that require credentials passed as environment variables. **Never hardcode tokens — always use environment variables.**
The pack uses three MCP servers that require credentials passed as environment variables. **Never hardcode tokens — always use environment variables.**

The other plugins doc files define how many MCPs are being used. This one just says "uses MCP servers".. It's not an error, but only for consistency, I would add:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants