Conversation
Collaborator
|
Thanks for this - it works as expected on my laptop. I'd like to double check the interaction with Live Share, but won't have access until tomorrow |
Member
Author
|
In a live share session, it looks like the guest does not handle |
ElianHugh
approved these changes
Nov 13, 2021
Collaborator
ElianHugh
left a comment
There was a problem hiding this comment.
Thank you for your patience - LGTM! Guests should have the host's httpgd session shared with them, but technically it is the host that is doing the attaching.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem did you solve?
Close #832
This PR moves the separate
httpgdrequest url into theattachrequest. If ahttpgddevice is open, then its url is also sent to session watcher on attach.This PR also removes the code to send
vsc.plotback to session watcher as it is already defined asr.session.viewers.viewColumn.plotin vscode settings.(If you do not have screenshot) How can I check this pull request?
plot(rnorm(100))and close the httpgd plot viewer.