Add r.session.levelOfObjectDetail=Normal for max.level=1#815
Merged
renkun-ken merged 3 commits intomasterfrom Oct 12, 2021
Merged
Add r.session.levelOfObjectDetail=Normal for max.level=1#815renkun-ken merged 3 commits intomasterfrom
r.session.levelOfObjectDetail=Normal for max.level=1#815renkun-ken merged 3 commits intomasterfrom
Conversation
|
How can I download this latest built? |
Member
Author
|
Download the artifact at https://github.com/REditorSupport/vscode-R/actions/runs/1327699240#artifacts which is at "Checks" -> "main push/pull request" -> artifacts. |
Collaborator
|
Sorry for the delay, been a bit swamped! I'll have a look over this now :) |
ElianHugh
approved these changes
Oct 12, 2021
Collaborator
ElianHugh
left a comment
There was a problem hiding this comment.
At first I didn't notice any difference between the three object detail settings, but I later realised this was because of the object timeout... Whoops! In that regard the fallback is pretty seamless!
As expected, minimal/normal settings do not occur a slowdown in comparison to detailed. Hover & str appear to be functioning as before.
LGTM! Thanks for the nice work!
ElianHugh
pushed a commit
to ElianHugh/vscode-R
that referenced
this pull request
May 12, 2022
…Support#815) * Add r.session.levelOfObjectDetail=Normal for max.level=1 * Add object timeout * Update capture_str
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem did you solve?
Closes #811
This PR
Normalto settingr.session.levelOfObjectDetailcorresponding tovsc.str.max.level=1so that the task callback performance is much better in most cases.r.session.objectTimeoutto limit the cpu time of eachcapture.output(str(obj, max.level=))call so that no single object takes too much time.(If you do not have screenshot) How can I check this pull request?
Use the following example to check the performance in each case where
r.session.levelOfObjectDetailisMinimal,NormalandDetailed.Both
MinimalandNormalshould have no notable performance issue, whileDetailedwould cause notable delay on user input.