Respect preview output format #785
Merged
renkun-ken merged 2 commits intoREditorSupport:masterfrom Sep 11, 2021
Merged
Conversation
Member
|
The rendering works now. But it seems the link to table 1 does not work: it will open in an external browser and go to a non-working URL. |
Collaborator
Author
|
Thanks for picking that up - it looks like this is something to do with how webviews convert links, as the anchors work in external browsers. Edit: |
Member
|
The anchor tags work nicely now. |
ElianHugh
added a commit
to ElianHugh/vscode-R
that referenced
this pull request
May 12, 2022
* Respect output format * Fix anchor tags
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #779
At the moment, previewing R Markdown documents forces the
rmarkdown::html_document()format. However, this overwrites all output formats, even if they can result in a .html file.This PR uses the object
pandoc$tofromrmarkdown:::create_output_formatto check if the document's output format == html. This way, we only override the output format ifpandoc$todoes not equal html.Screenshot
How can I check this pull request?
The following renders incorrectly on master, which is fixed in this PR: