Merged
Conversation
ElianHugh
approved these changes
Sep 9, 2021
Collaborator
ElianHugh
left a comment
There was a problem hiding this comment.
LGTM! In the future we could probably look at comparators for sorting the values properly
Member
Author
|
It looks like JavaScript has support for NaN and infinite values but JSON has no way to represent them. We are only using jsonlite to write the structure to be inserted as part of the HTML, not really reading it as json anyway. In the future, we might have a better way to simply produce the correct JavaScript object directly. |
ElianHugh
pushed a commit
to ElianHugh/vscode-R
that referenced
this pull request
May 12, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem did you solve?
Closes #776
Since JSON does not support
NA,NaN,Infvalues, they can only be written as strings in the following way:One remaining issue is that these values will not work properly when filtering is used in the data viewer, i.e. if one filters a column by "Greater than 0",
Infis not regarded as Inf > 0 but ignored.(If you have)Screenshot
How can I check this pull request?
The following code should open a data viewer where
InfandNAvalues are correctly displayed in the data grid.