Add object length limit#778
Merged
renkun-ken merged 3 commits intoREditorSupport:masterfrom Sep 9, 2021
Merged
Conversation
Collaborator
|
Thanks for the quick fix! I've had a look over the commit and it looks good. I'll have a chance to try the PR in an hour or so |
Collaborator
|
Thank you for the good work, it all works quite nicely! The only (very minor) issue I've had is the console complaining about undefined properties: Error Cannot read property 'map' of undefined: TypeError: Cannot read property 'map' of undefined
at LiveCompletionItemProvider.provideCompletionItems (/home/elian/Documents/Coding/vscode-R/out/completions.js:111:22)
at $.provideCompletionItems (/var/lib/snapd/snap/code/73/usr/share/code/resources/app/out/vs/workbench/services/extensions/node/extensionHostProcess.js:94:176938) |
Member
Author
|
I made some changes to the completions to achieve the following:
|
ElianHugh
pushed a commit
to ElianHugh/vscode-R
that referenced
this pull request
May 12, 2022
* Add object length limit * Update inspect_env * Preserve the order of names in completion
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem did you solve?
Closes #174
This PR introduces a new setting
r.session.objectLengthLimitcorresponding to R optionvsc.object_length_limitto limit the length of objects to provide names in session symbol completion, hover, and workspace viewer item.Then large named objects with many elements will not be called
names(). The overhead of callingnames()(on environment) and writing the names toglobalenv.jsonshould be reduced.(If you do not have screenshot) How can I check this pull request?
For the following code, before this PR, the delay will be more and more significant if more objects with many elements are created in the global environment.
With this PR being effective, creating
lst2andlst3should no longer cause a permanent delay on all subsequent calculations. One should also observe that the auto-completion works withlst1but notlst2orlst3due to object length limit, and the workspace viewer item oflst1should show object details whilelst2andlst3do not ifr.session.levelOfObjectDetailis set toDetailed. Adjustingr.session.objectLengthLimitshould work accordingly.